Make CI working again #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felixoid
commented
Jul 30, 2021
| @@ -36,8 +36,7 @@ install: | |||
| .PHONY: install | |||
|
|
|||
| install-dependencies: | |||
| go mod vendor | |||
There was a problem hiding this comment.
Sorry, I am not sure why go mod vendor is used here. But it's useless without either -mod=vendor flag for all go commands or GOFLAGS=-mod=vendor env variable.
|
Awesome work! 🎉 |
Felixoid
force-pushed
the
mCIga
branch
2 times, most recently
from
333bd36 to
25b15af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes I've done:
getcommands where they are used as binary installation, see https://golang.org/doc/go-get-install-deprecationinstall-dependenciestargetgolintto have it working with modulesIt fixes #82
To see it's working check https://github.com/Felixoid/go-mutesting/pull/1/checks